Bug 547605 - multiple submitreqs break ...
Summary: multiple submitreqs break ...
Status: NEW
Alias: None
Product: openSUSE.org
Classification: openSUSE
Component: BuildService (show other bugs)
Version: unspecified
Hardware: Other Other
: P5 - None : Normal (vote)
Target Milestone: ---
Assignee: Marcus Hüwe
QA Contact: Adrian Schröter
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-16 12:00 UTC by Michael Meeks
Modified: 2011-03-14 12:59 UTC (History)
0 users

See Also:
Found By: ---
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Meeks 2009-10-16 12:00:26 UTC 
Now that osc request accept appears to delete a home:... branch of a package, it is easy to create a mess:

osc sr -m 'fix my bug' Moblin:UI
osc sr -m 'fix my bug' Moblin:Factory

results in two requests, both of which are fine, until one is accepted - at which point the other breaks - with some broken/deleted link goodness.

It would be preferable if you could only submit once, or at least get a warning, or (perhaps) not delete the source until there are no pending submitrequests on a package (?).
Comment 1 Sascha Peilicke 2011-03-14 12:39:52 UTC 
Actually, the webui asks for this specifically, seems like osc doesn't.

@Marcus: does it?
Comment 2 Marcus Hüwe 2011-03-14 12:51:04 UTC 
No osc doesn't ask for it but it offers the "--no-cleanup" option. By default the "submitrequest_on_accept_action" config option is used (if nothing else is specified) which is by default empty. Therefore the api decides what happens with a source package after the accept.
Comment 3 Sascha Peilicke 2011-03-14 12:59:18 UTC 
Actually, in this specific case, the API should have checked if there are any pending requests based on this source package and don't remove it (even if asked to) until all related requests are handled.