Bug 574266 - VUL-0: NetworkManager unsafe for WPA2 Enterprise networks
Summary: VUL-0: NetworkManager unsafe for WPA2 Enterprise networks
Status: CONFIRMED
Alias: None
Product: SUSE Security Incidents
Classification: Novell Products
Component: General (show other bugs)
Version: unspecified
Hardware: Other Other
: P1 - Urgent : Major
Target Milestone: ---
Deadline: 2011-11-01
Assignee: Gary Ching-Pang Lin
QA Contact: Security Team bot
URL:
Whiteboard: maint:released:11.3:43947 maint:relea...
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-27 10:19 UTC by Ludwig Nussel
Modified: 2019-08-06 07:38 UTC (History)
10 users (show)

See Also:
Found By: Security Response Team
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---


Attachments
wpa_supplicant-notify-certification-dbus.patch (10.49 KB, patch)
2011-06-15 10:30 UTC, Michael Chang
Details | Diff
Backported subject matching patch (26.81 KB, patch)
2011-08-31 08:43 UTC, Gary Ching-Pang Lin
Details | Diff
Concept proof patch for nm-applet (15.05 KB, patch)
2011-09-02 06:38 UTC, Gary Ching-Pang Lin
Details | Diff
concept-proof NM dbus probe method (16.15 KB, patch)
2011-09-09 07:05 UTC, Gary Ching-Pang Lin
Details | Diff
concept-proof nm-applet preset subject (3.48 KB, patch)
2011-09-09 09:07 UTC, Gary Ching-Pang Lin
Details | Diff
Improved NM patch to support server hash (17.03 KB, patch)
2011-09-13 09:07 UTC, Gary Ching-Pang Lin
Details | Diff
Improved nm-applet patch to preset subject and server hash (7.72 KB, patch)
2011-09-13 09:09 UTC, Gary Ching-Pang Lin
Details | Diff
NetworkManager Probe CA Certificate (17.90 KB, patch)
2011-09-19 07:11 UTC, Gary Ching-Pang Lin
Details | Diff
nm-applet Probe CA Certificate (10.57 KB, patch)
2011-09-19 07:12 UTC, Gary Ching-Pang Lin
Details | Diff
nm-applet Probe CA Certificate (Updated) (9.94 KB, patch)
2011-09-19 10:30 UTC, Gary Ching-Pang Lin
Details | Diff
NetworkManager Probe CA Certificate (17.69 KB, patch)
2011-10-03 07:22 UTC, Gary Ching-Pang Lin
Details | Diff
nm-applet Probe CA Certificate (29.64 KB, patch)
2011-10-04 03:43 UTC, Gary Ching-Pang Lin
Details | Diff
nm log file (3.50 KB, text/plain)
2011-10-06 09:25 UTC, Ludwig Nussel
Details
nm-applet Probe CA Certificate (29.38 KB, patch)
2011-10-12 03:38 UTC, Gary Ching-Pang Lin
Details | Diff
NetworkManager Probe CA Certificate (17.61 KB, patch)
2011-10-12 03:45 UTC, Gary Ching-Pang Lin
Details | Diff
nm-applet Probe CA Certificate (34.46 KB, patch)
2011-10-18 10:15 UTC, Gary Ching-Pang Lin
Details | Diff
nm-applet Probe CA Certificate (34.61 KB, patch)
2011-10-20 09:28 UTC, Gary Ching-Pang Lin
Details | Diff
NetworkManager 0.6.6 set eap subject (7.98 KB, patch)
2012-01-17 02:40 UTC, Gary Ching-Pang Lin
Details | Diff
nm-applet 0.6.6 add the subject entry to the WPA-EAP settings dialog (18.61 KB, patch)
2012-01-17 02:48 UTC, Gary Ching-Pang Lin
Details | Diff
nm-applet 0.6.6 add the subject entry to the WPA-EAP settings dialog (18.43 KB, patch)
2012-01-30 09:39 UTC, Gary Ching-Pang Lin
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ludwig Nussel 2010-01-27 10:19:13 UTC
This issue is not public yet, please keep any information about it inside SUSE.

WPA2 Enterprise networks using EAP-TTLS or PEAP rely on clients to
verify the certificate of the RADIUS server even more than EAP-TLS.
Failure to verify the certificate allows attackers to forge the
network and the RADIUS server to steal user credentials.

There are three ways of how a certificate can be signed:

1. self signed
2. signed by a custom CA wherein
   a) the CA certificate is available to the client
   b) the CA certificate is not available to the client
3. signed by a standard CA as used on the internet

Those cases different methods to verify the certificate are needed.
The client software

- case 1: MUST verify that the certificate presented by the RADIUS
  server matches a local reference copy.

- case 2:
  a)
  - MUST verify that the certificate presented by the RADIUS
    server is signed by the specified CA certificate.
  - MUST verify that the CN of the certificate presented by the
    RADIUS server matches a specified string. This is OPTIONAL if
    the CA certificate is guaranteed to be only used for signing
    the certificate of the RADIUS server.
  b)
  MUST verify that the certificate presented by the RADIUS server
  matches a local reference copy.

- case 3:
  - MUST verify that the certificate presented by the RADIUS server
    is signed by one of the system's CA certificates.
  - MUST verify that the CN of the certificate presented by the
    RADIUS server matches a specified string.

NetworkManager lacks options to match the RADIUS' servers
certificate against a local reference copy.

NetworkManager also doesn't allow to specify a CN.

NetworkManager does allow to specify a CA certificate for
verfication of the RADIUS' servers certificate.

Therefore NetworkManager is only safe to use in case 2a.
NetworkManager cannot perform the required checks for case 1, 2b and
3. If used in those cases nevertheless NetworkManager jeopardizes
the security of the wireless network.
Comment 10 Ludwig Nussel 2010-02-15 09:51:27 UTC
meanwhile I've contacted upstream. Jouni started implementing the needed features in wpa_supplicant:
http://w1.fi/gitweb/gitweb.cgi?p=hostap.git;a=log;h=00468b4650998144f794762206c695c962c54734
Comment 11 Ludwig Nussel 2010-03-01 10:32:54 UTC
So it's NetworkManager's turn to make use of this interface I guess. Dan Williams could use some help AFAICT.
Comment 13 Ludwig Nussel 2010-04-26 12:42:08 UTC
Meanwhile I've published the paper:
http://www.openwall.com/lists/oss-security/2010/04/22/2
Comment 18 Ludwig Nussel 2010-11-29 10:57:05 UTC
https://features.opensuse.org/309931
Comment 41 Bin Li 2011-07-31 07:59:06 UTC
Hi,
 Someone already  arrive first and submit the patch for NetworkManager. What we need to do is backport the patch. And also the NetworkManager-gnome's patch will be come soon.

http://mail.gnome.org/archives/networkmanager-list/2011-July/msg00212.html
Comment 97 Ludwig Nussel 2011-10-18 13:32:34 UTC
CVE-2006-7246
Comment 110 Bernhard Wiedemann 2011-10-25 08:00:12 UTC
This is an autogenerated message for OBS integration:
This bug (574266) was mentioned in
https://build.opensuse.org/request/show/89232 11.4 / wpa_supplicant
https://build.opensuse.org/request/show/89233 11.4 / NetworkManager
https://build.opensuse.org/request/show/89234 11.4 / NetworkManager-gnome
https://build.opensuse.org/request/show/89235 11.3 / wpa_supplicant
https://build.opensuse.org/request/show/89236 11.3 / NetworkManager
https://build.opensuse.org/request/show/89237 11.3 / NetworkManager-gnome
Comment 112 Ludwig Nussel 2011-10-26 13:17:34 UTC
Is there any way to warn the user if he uses an old connection that does not perform the necessary certificate checks? Right now users will install the NM update but will not gain any security unless the manually delete and add their connection again AFAICS.
Comment 113 Gary Ching-Pang Lin 2011-10-27 09:06:17 UTC
A possible solution is to check the subject and ca_cert/cert_hash when connecting to a TTLS/PEAP AP and marked the connection as NEED_SECRET to force nm-applet to show the settings dialog to setup the connection properly. The problem is: any NM client other than nm-applet, e.g. NetworkManager Plasmoid, will not be able to connect to TTLS/PEAP APs unless it also implements the feature.
Comment 114 Ludwig Nussel 2011-10-27 09:29:46 UTC
That would increase the pressure to fix the bug in KDE as well I guess :-)
Comment 115 Ludwig Nussel 2011-10-27 09:31:41 UTC
Let's proceed with the current state to not delay the update for GNOME any further. As soon as KDE is fixed too we may release another NM update that also converts the existing connections.
Comment 123 Bernhard Wiedemann 2011-11-15 11:00:12 UTC
This is an autogenerated message for OBS integration:
This bug (574266) was mentioned in
https://build.opensuse.org/request/show/91468 12.1 / wpa_supplicant
https://build.opensuse.org/request/show/91471 12.1 / NetworkManager
https://build.opensuse.org/request/show/91474 12.1 / NetworkManager-gnome
https://build.opensuse.org/request/show/91476 12.1 / gnome-control-center
Comment 124 Swamp Workflow Management 2011-11-22 13:04:14 UTC
Update released for: NetworkManager, NetworkManager-debuginfo, NetworkManager-debugsource, NetworkManager-devel, NetworkManager-doc, NetworkManager-glib, NetworkManager-glib-debuginfo, NetworkManager-gnome, NetworkManager-gnome-debuginfo, NetworkManager-gnome-debugsource, NetworkManager-gnome-lang, NetworkManager-lang, wpa_supplicant, wpa_supplicant-debuginfo, wpa_supplicant-debugsource, wpa_supplicant-gui, wpa_supplicant-gui-debuginfo
Products:
openSUSE 11.3 (debug, i586, x86_64)
openSUSE 11.4 (debug, i586, x86_64)
Comment 125 Swamp Workflow Management 2011-11-22 16:20:07 UTC
Update released for: NetworkManager, NetworkManager-debuginfo, NetworkManager-debugsource, NetworkManager-devel, NetworkManager-doc, NetworkManager-glib, NetworkManager-gnome, NetworkManager-gnome-debuginfo, NetworkManager-gnome-debugsource, wpa_supplicant, wpa_supplicant-debuginfo, wpa_supplicant-debugsource, wpa_supplicant-gui
Products:
SLE-DEBUGINFO 11-SP1 (i386, ia64, ppc64, s390x, x86_64)
SLE-DESKTOP 11-SP1 (i386, x86_64)
SLE-SDK 11-SP1 (i386, ia64, ppc64, s390x, x86_64)
SLE-SERVER 11-SP1 (i386, ia64, ppc64, s390x, x86_64)
SLE-SERVER 11-SP1-TERADATA (x86_64)
SLES4VMWARE 11-SP1 (i386, x86_64)
Comment 136 Bernhard Wiedemann 2012-01-05 03:00:11 UTC
This is an autogenerated message for OBS integration:
This bug (574266) was mentioned in
https://build.opensuse.org/request/show/98818 11.3 / NetworkManager-gnome
https://build.opensuse.org/request/show/98819 11.4 / NetworkManager-gnome
https://build.opensuse.org/request/show/98820 12.1 / NetworkManager-gnome
Comment 137 Bernhard Wiedemann 2012-01-10 10:00:10 UTC
This is an autogenerated message for OBS integration:
This bug (574266) was mentioned in
https://build.opensuse.org/request/show/99575 Factory / wpa_supplicant
Comment 139 Gary Ching-Pang Lin 2012-01-17 02:40:17 UTC
Created attachment 471436 [details]
NetworkManager 0.6.6 set eap subject
Comment 140 Gary Ching-Pang Lin 2012-01-17 02:48:39 UTC
Created attachment 471437 [details]
nm-applet 0.6.6 add the subject entry to the WPA-EAP settings dialog

Besides adding the subject entry, this patch also does a simple validation for the WPA-EAP settings, by checking the identity, password, client certificate file, and private key. The most important of all, both the CA certificate file and the subject are now mandatory.
Comment 143 Ludwig Nussel 2012-01-17 15:10:00 UTC
AFAICT the patch works fine, thanks!
Comment 146 Gary Ching-Pang Lin 2012-01-30 09:39:47 UTC
Created attachment 473209 [details]
nm-applet 0.6.6 add the subject entry to the WPA-EAP settings dialog

Update the nm-applet patch to remove the identity check for EAP-TLS.
Comment 151 Swamp Workflow Management 2012-02-15 16:03:14 UTC
Update released for: NetworkManager-gnome, NetworkManager-gnome-debuginfo, NetworkManager-gnome-debugsource
Products:
SLE-DEBUGINFO 11-SP1 (i386, ia64, ppc64, s390x, x86_64)
SLE-DESKTOP 11-SP1 (i386, x86_64)
SLE-SERVER 11-SP1 (i386, ia64, ppc64, s390x, x86_64)
SLE-SERVER 11-SP1-TERADATA (x86_64)
SLES4VMWARE 11-SP1 (i386, x86_64)
Comment 152 Swamp Workflow Management 2012-02-18 06:08:40 UTC
Update released for: NetworkManager, NetworkManager-debuginfo, NetworkManager-devel, NetworkManager-glib, NetworkManager-gnome, wpa_supplicant, wpa_supplicant-debuginfo, wpa_supplicant-gui
Products:
SLE-SERVER 10-SP3-TERADATA (x86_64)
Comment 153 Swamp Workflow Management 2012-02-18 08:55:56 UTC
Update released for: NetworkManager, NetworkManager-debuginfo, NetworkManager-devel, NetworkManager-glib, NetworkManager-gnome, wpa_supplicant, wpa_supplicant-debuginfo, wpa_supplicant-gui
Products:
SLE-DEBUGINFO 10-SP4 (i386, ia64, ppc, s390x, x86_64)
SLE-DESKTOP 10-SP4 (i386, x86_64)
SLE-SERVER 10-SP4 (i386, ia64, ppc, s390x, x86_64)
Comment 158 Bernhard Wiedemann 2013-04-03 08:00:11 UTC
This is an autogenerated message for OBS integration:
This bug (574266) was mentioned in
https://build.opensuse.org/request/show/162340 Maintenance /
Comment 159 Swamp Workflow Management 2013-04-12 07:05:27 UTC
openSUSE-RU-2013:0673-1: An update that has two recommended fixes can now be installed.

Category: recommended (low)
Bug References: 574266,798793
CVE References: 
Sources used:
openSUSE 12.3 (src):    NetworkManager-0.9.6.4-5.6.1, NetworkManager-gnome-0.9.6.4-2.5.1, gnome-control-center-3.6.3-3.14.1
Comment 160 Bernhard Wiedemann 2013-05-12 19:00:13 UTC
This is an autogenerated message for OBS integration:
This bug (574266) was mentioned in
https://build.opensuse.org/request/show/175192 Factory / NetworkManager
Comment 161 Bernhard Wiedemann 2013-10-07 09:00:31 UTC
This is an autogenerated message for OBS integration:
This bug (574266) was mentioned in
https://build.opensuse.org/request/show/202472 Factory / NetworkManager-gnome
https://build.opensuse.org/request/show/202475 Factory / gnome-control-center