Bugzilla – Bug 64408
VUL-0: CVE-2004-1261: buffer overflow in asp2php
Last modified: 2021-10-02 09:00:12 UTC
We received the following report. The issue is public. The attack scenario for this one sounds rather constructed. I think we can continue the current php update without fix for this. From djb@cr.yp.to Wed Dec 15 14:21:44 2004 Date: 15 Dec 2004 08:21:54 -0000 From: D. J. Bernstein <djb@cr.yp.to> To: securesoftware@list.cr.yp.to, mike@mikekohn.net Subject: [remote] [control] asp2php 0.76.23 preparse() overflows token buffer; preparse() overflows temp buffer Qiao Zhang, a student in my Fall 2004 UNIX Security Holes course, has discovered two remotely exploitable security holes in asp2php. I'm publishing this notice, but all the discovery credits should be assigned to Zhang. You are at risk if you take an ASP script from an email message (or a web page or any other source that could be controlled by an attacker) and feed that script through asp2php. (The asp2php documentation does not tell users to avoid taking input from the network.) Whoever provides that script then has complete control over your account: she can read and modify your files, watch the programs you're running, etc. Proof of concept: On an x86 computer running FreeBSD 4.10, type wget http://downloads.mikekohn.net/asp2php/asp2php-0.76.23.tar.gz gunzip < asp2php-0.76.23.tar.gz | tar -xf - cd asp2php-0.76.23 make to download and compile the asp2php program, version 0.76.23 (current). Then save the file 29-1.asp attached to this message, and type ./asp2php 29-1.asp with the unauthorized result that a file named EXPLOITED is created in the current directory. 29-2.asp is similar but uses a separate buffer overflow. (I tested these with a 541-byte environment, as reported by printenv | wc -c.) Both buffer overflows can be blamed on gettoken(), which has a fundamentally broken gets()-style API. The preparse() function calls gettoken() to read data into a 1024-byte token[] array, and to read data into a 1024-byte temp[] array. ---D. J. Bernstein, Associate Professor, Department of Mathematics, Statistics, and Computer Science, University of Illinois at Chicago [ Part 2, Text/PLAIN (charset: unknown-8bit) 32 lines. ] [ Unable to print this part. ] [ Part 3, Text/PLAIN (charset: unknown-8bit) 45 lines. ] [ Unable to print this part. ]
since you have to run asp2php by hand (we currently do not do that automatically at this time), this is a minor issue. we can fix it with the next php4 update.
====================================================== Candidate: CAN-2004-1261 URL: http://cve.mitre.org/cgi-bin/cvename.cgi?name=CAN-2004-1261 Reference: MISC:http://tigger.uic.edu/~jlongs2/holes/asp2php.txt Multiple buffer overflows in the preparse function in asp2php 0.76.23 allow remote attackers to execute arbitrary code via crafted ASP scripts.
Okay, I will try to not forget on this in next php update.
Have you seen patch for this issue?
As there seems to be another report for php - bug# 50565, so I'd like to see patch for this so that I can work on this.
There was no patch. I just looked at the code, this thing is broken beyond repair. It uses strcpy/strcat/sprintf without any checks all over the place. Is asp2php executed automatically in any configuration or does the user always need to manually invoke it? If the latter is the case I'd say forgit it in old distros and drop it in STABLE.
User needs to start it manually.
i suggest: no need to fix this script. please consider dropping it in STABLE / for 9.3.
I filed drop request.
CVE-2004-1261: CVSS v2 Base Score: 10.0 (AV:N/AC:L/Au:N/C:C/I:C/A:C)