Bug 838185 - MODULES_LOADED_ON_BOOT removed
Summary: MODULES_LOADED_ON_BOOT removed
Status: RESOLVED FIXED
Alias: None
Product: openSUSE Tumbleweed
Classification: openSUSE
Component: YaST2 (show other bugs)
Version: 13.1 Milestone 3
Hardware: x86-64 Linux
: P5 - None : Normal (vote)
Target Milestone: ---
Assignee: Lukas Ocilka
QA Contact: Jiri Srain
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-03 12:48 UTC by Olaf Hering
Modified: 2014-02-06 09:33 UTC (History)
4 users (show)

See Also:
Found By: Outsourced Testing
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Olaf Hering 2013-09-03 12:48:36 UTC 
In bnc#768423 it was requested to migrate  /etc/sysconfig/kernel:MODULES_LOADED_ON_BOOT to /etc/modules-load.d/
This is change is now in Factory. Today I searched for other users of MODULES_LOADED_ON_BOOT and found several in the yast sources.

systemd still processes /etc/sysconfig/kernel:MODULES_LOADED_ON_BOOT, but I think thats a SuSE specific change.


Please pass this bug around to update the remaining cases.

linuxrc-4.1.5/net.c:2429:      fprintf(fpk, "MODULES_LOADED_ON_BOOT=\"$MODULES_LOADED_ON_BOOT netiucv\"\n");

yast2-bootloader-3.0.3/src/modules/Bootloader.rb:333
yast2-installation-3.0.4/src/clients/kernel_finish.rb:156
yast2-sound-3.0.1/src/include/sound/write_routines.rb:136
yast2-storage-3.0.2/src/modules/Storage.rb:5968
yast2-3.0.5/library/system/src/modules/Kernel.rb:584
yast2-3.0.5/library/system/testsuite/tests/kernel.out:5


There are probably more, my grep through all Factory sources is not yet done.
Comment 1 Arvin Schnell 2013-09-03 15:08:38 UTC 
linuxrc and yast2-bootloader -> Steffen
Comment 2 Olaf Hering 2013-09-03 15:17:52 UTC 
(In reply to comment #0)

> There are probably more, my grep through all Factory sources is not yet done.

My grep found no more references to MODULES_LOADED_ON_BOOT
Comment 3 Forgotten User VwC0v2dy2L 2013-10-06 23:27:35 UTC 
can you please add /etc/sysconfig/kernel:MODULES_LOADED_ON_BOOT_REMOVED with documentation how to use /etc/modules-load.d/ ?
Comment 4 Lukas Ocilka 2013-10-29 16:02:10 UTC 
Michal, this is what I've found: http://www.freedesktop.org/software/systemd/man/modules-load.d.html
Comment 5 Forgotten User VwC0v2dy2L 2013-10-29 18:59:42 UTC 
@Lukas I figured it out with time, but the entry pointing to documentation would help others to find it instead of googling around and scratching head
Comment 6 Olaf Hering 2013-10-29 19:02:22 UTC 
Perhaps that should either go into release-notes or in a preserved comment in the new .conf file.
Comment 7 Forgotten User VwC0v2dy2L 2013-10-29 20:54:05 UTC 
a full variable like MODULES_LOADED_ON_BOOT_REMOVED would show in the yast sysconfig module - this is where I was searching for MODULES_LOADED_ON_BOOT
Comment 8 Lukas Ocilka 2013-10-30 09:57:11 UTC 
Taking this one ... for a while
Comment 9 Lukas Ocilka 2013-11-04 15:23:23 UTC 
I've fixed this for openSUSE factory by reimplementing the internal handling:
https://github.com/yast/yast-yast2/pull/131/files

Coolo, do you want to have this fix in 13.1 as well? It's in the installation.
Comment 10 Stephan Kulow 2013-11-05 07:36:22 UTC 
No, actually I only want ship stoppers fixed at this point.
Comment 11 Lukas Ocilka 2013-11-11 12:56:31 UTC 
All except Storage (https://github.com/yast/yast-storage/pull/13)
has been fixed and merged and will be in Factory.
Comment 12 Arvin Schnell 2014-02-06 09:33:20 UTC 
The code in yast2-storage has been removed, for details see https://github.com/yast/yast-storage/pull/19.