Bug 846422 - systemctl --type=service list-unit-files doesn't show LSB wrapped ones
Summary: systemctl --type=service list-unit-files doesn't show LSB wrapped ones
Status: RESOLVED FIXED
: 840159 845795 (view as bug list)
Alias: None
Product: openSUSE 13.1
Classification: openSUSE
Component: YaST2 (show other bugs)
Version: RC 1
Hardware: Other Other
: P5 - None : Major (vote)
Target Milestone: ---
Assignee: Vladimir Moravec
QA Contact: Jiri Srain
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-17 13:41 UTC by Michal Hrusecky
Modified: 2018-10-26 07:44 UTC (History)
7 users (show)

See Also:
Found By: ---
Services Priority:
Business Priority:
Blocker: Yes
Marketing QA Status: ---
IT Deployment: ---
coolo: SHIP_STOPPER-


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michal Hrusecky 2013-10-17 13:41:08 UTC
'systemctl --type=service list-unit-files' doesn't show LSB services which are showed only using 'systemctl --type=service list-units --all' which output on the other hand doesn't show whether services are enabled or not.

Why major ship stopper: list-unit-files is used and parsed by YaST to provide service manager. Currently it only shows native systemd services, which we are still missing for some important services like xdm or MySQL. So fixing it to show even LSB services is quite crucial for 13.1 release. Other option would be to parse list-units command in YaST and call status on each of them, which would be quite slow and ugly work around.
Comment 1 Michal Hrusecky 2013-10-17 13:43:24 UTC
*** Bug 840159 has been marked as a duplicate of this bug. ***
Comment 2 Frederic Crozat 2013-10-17 14:19:20 UTC
the description for "list-unit-files" is quite explicit in systemd manpage and it is a defined D-Bus API I can't modify without upstream approval (and it would requires a lot of changes, at least, until LSB initscripts handling is done with systemd generator, which is on systemd TODO list but not done yet).

I've looked at how it is done in systemd-ui (http://cgit.freedesktop.org/systemd/systemd-ui/):
 - it is using D-Bus to access those informations (so no executable nor parsing involve)
 - it calls the D-BUS API equivalent to list-units --all and get D-Bus properties on each returned object to display.
Comment 3 Stephan Kulow 2013-10-17 14:48:02 UTC
Michal: the release manager sets ship stopper flag + or -. You're supposed to set the flag to ? with me in the input field behind it
Comment 4 Tomáš Chvátal 2013-10-17 15:11:52 UTC
(In reply to comment #3)
> Michal: the release manager sets ship stopper flag + or -. You're supposed to
> set the flag to ? with me in the input field behind it

My bad, I told him to do it this way as I thought it is proper approach.
Comment 5 Michal Hrusecky 2013-10-21 13:42:58 UTC
Ok, so you are saying that there is no easy way to make it behave same like list-units and that YaST guys has to find a different way how to detect states (query state for all LSB units manually or use D-Bus API), right? So back to YaST?
Comment 6 Frederic Crozat 2013-10-21 14:08:58 UTC
unfortunately, yes. Sorry :(
Comment 7 Stephan Kulow 2013-10-23 09:41:15 UTC
I disagree with the ship stopper status. 12.3 has no fully working system service editor either
Comment 8 Vladimir Moravec 2013-10-24 13:48:17 UTC
*** Bug 845795 has been marked as a duplicate of this bug. ***
Comment 9 Lukas Ocilka 2013-10-31 20:44:52 UTC
Vlado, to my knowledge you plan to change the behavior. Am I right?
Comment 10 Vladimir Moravec 2013-11-01 14:04:30 UTC
(In reply to comment #9)
> Vlado, to my knowledge you plan to change the behavior. Am I right?

Yes, this is the proposal for including the lsb-wrapped services: https://github.com/yast/yast-services-manager/pull/33
Comment 11 Bernhard Wiedemann 2013-11-04 15:00:10 UTC
This is an autogenerated message for OBS integration:
This bug (846422) was mentioned in
https://build.opensuse.org/request/show/205715 13.1 / yast2-services-manager
Comment 12 Vladimir Moravec 2013-11-05 08:06:25 UTC
Maintenance request for opensuse-13.1:Update accepted.
Comment 13 Swamp Workflow Management 2013-11-15 18:09:54 UTC
openSUSE-RU-2013:1711-1: An update that has one recommended fix can now be installed.

Category: recommended (low)
Bug References: 846422
CVE References: 
Sources used:
openSUSE 13.1 (src):    yast2-services-manager-0.0.11-3.4.1