Bug 915323 - (CVE-2015-0210) VUL-0: CVE-2015-0210: wpa_supplicant: broken certificate subject check
VUL-0: CVE-2015-0210: wpa_supplicant: broken certificate subject check
Classification: Novell Products
Product: SUSE Security Incidents
Classification: Novell Products
Component: Incidents
Other Other
: P3 - Medium : Normal
: ---
Assigned To: Ruediger Oertel
Security Team bot
Depends on:
  Show dependency treegraph
Reported: 2015-01-29 09:25 UTC by Victor Pereira
Modified: 2018-12-14 07:50 UTC (History)
7 users (show)

See Also:
Found By: Security Response Team
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---


Note You need to log in before you can comment on or make changes to this bug.
Description Victor Pereira 2015-01-29 09:25:16 UTC

It was reported [1] that wpa_supplicant does not properly check certificate subject name, which might lead to "man in the middle" attack.
Relevant part of the original report:

wpa_supplicant, linked against openssl performs this check:

    if (depth == 0 && match && os_strstr(buf, match) == NULL) {
        wpa_printf(MSG_WARNING, "TLS: Subject '%s' did not "
               "match with '%s'", buf, match);
        preverify_ok = 0;
        openssl_tls_fail_event(conn, err_cert, err, depth, buf,
                       "Subject mismatch",

strstr() is vulnerable to extension attack, for instance, one would like to
match on /CN=wireless.nikhef.nl, but explicitly not match on
wireless.nikhef.nl.honestachmed.tr. There is no way to implement a secure
EAP-TTLS/PEAP configuration using public certificates this way.

When linked against GnuTLS, the problem is even worse:

      if (i == 0) {
            /* TODO: validate subject_match and altsubject_match */

Now, it is current best practice to run EAP-TTLS/PEAP with public certificates,
because on Windows, this automatically pins the CN and CA from the certificate.

[1]: https://bugzilla.redhat.com/show_bug.cgi?id=1178263
Comment 1 Marcus Meissner 2015-01-29 17:32:48 UTC
Gary is also maintainer on older products.
Comment 2 Swamp Workflow Management 2015-01-29 23:00:25 UTC
bugbot adjusting priority
Comment 4 Ruediger Oertel 2015-02-27 12:58:35 UTC
well, the patches from RH basically are:

the first one adds the "domain_match" config option. Our version 2.2
already had "domain_suffix_match". I've adapted the patch, now
we should actually have both, "domain_match" and "domain_suffix_match"
acting as the naming implies.

submitting as soon as it builds.
Comment 7 Swamp Workflow Management 2015-03-09 10:24:42 UTC
An update workflow for this issue was started.
This issue was rated as moderate.
Please submit fixed packages until 2015-03-23.
When done, reassign the bug to security-team@suse.de.
Comment 15 Victor Pereira 2015-06-02 06:07:24 UTC
ping! We need the submissions for SLE-11-SP2
Comment 16 Victor Pereira 2015-06-02 08:56:32 UTC
after a long discussion with upstream, the bug was marked as invalid. Plese check https://bugzilla.gnome.org/show_bug.cgi?id=341323#c28 for more information.
Comment 17 Swamp Workflow Management 2015-06-09 08:05:25 UTC
SUSE-SU-2015:1013-1: An update that fixes three vulnerabilities is now available.

Category: security (moderate)
Bug References: 900611,915323,927558
CVE References: CVE-2014-3686,CVE-2015-0210,CVE-2015-1863
Sources used:
SUSE Linux Enterprise Server 12 (src):    wpa_supplicant-2.2-8.1
SUSE Linux Enterprise Desktop 12 (src):    wpa_supplicant-2.2-8.1
Comment 18 Andreas Stieger 2015-07-02 14:50:56 UTC

Looks like this is still going.
Comment 21 Ruediger Oertel 2015-10-27 01:10:30 UTC
combined with the other set of fixes.
created request id 76374

this has now:
Thu May  7 17:10:30 CEST 2015 - ro@suse.de

- added patch for bnc#930077
- added patch for bnc#930078

Wed Apr 22 12:13:26 CEST 2015 - ro@suse.de

- add changes for bnc#915323:
  - added wpa_supplicant-tls-domain-suffix.patch to support the
    domain_suffix_match option (prereq for following changes)
    based on original git commit from Oct 6th 2013
  - added wpa_supplicant-cert_in_cb.patch to add the option
    to write the server cert chain to a file
    based on original git commit from Sep 17th 2011
    and parts of 4f525d8e5bc6ea89062d70044ee583f11af4126b
  - added 0013-rh1178263-CVE-2015-0210-domain_match.patch
    this adds the "domain_match" config option from upstream
  - added 0014-rh1178263-CVE-2015-0210-cert_in_cb.patch
    (include peer certificate always in EAP events by default,
     can be disabled with cert_in_cb=0)
Comment 25 Ruediger Oertel 2018-05-03 10:55:07 UTC
okay ... CVE-2015-1863 is not applicable for the 11-sp2 variant
CVE-2014-3686 was already listed.
CVE-2015-0210 was only there as part of a string, added

hope it's correct now.
Comment 28 Swamp Workflow Management 2018-06-12 19:13:23 UTC
SUSE-SU-2018:1659-1: An update that fixes one vulnerability is now available.

Category: security (moderate)
Bug References: 915323
CVE References: CVE-2015-0210
Sources used:
SUSE Linux Enterprise Server 11-SP4 (src):    wpa_supplicant-0.7.1-
Comment 29 Karol Babioch 2018-11-14 14:21:15 UTC
Fixed for all current codestreams.