Bug 938913 - VUL-1: socat: The Logjam Attack / weakdh.org
VUL-1: socat: The Logjam Attack / weakdh.org
Status: RESOLVED FIXED
Classification: Novell Products
Product: SUSE Security Incidents
Classification: Novell Products
Component: Incidents
unspecified
Other Other
: P3 - Medium : Major
: ---
Assigned To: Marcus Meissner
Security Team bot
:
Depends on:
Blocks: CVE-2015-4000
  Show dependency treegraph
 
Reported: 2015-07-21 11:27 UTC by Marcus Meissner
Modified: 2016-04-27 19:17 UTC (History)
15 users (show)

See Also:
Found By: ---
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---


Attachments
Defend against pre-computed DH attacks. (1.93 KB, patch)
2016-02-04 09:26 UTC, Peter Simons
Details | Diff
Defend against pre-computed DH attacks. (2.96 KB, patch)
2016-02-04 09:29 UTC, Peter Simons
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Marcus Meissner 2015-07-21 11:27:54 UTC
+++ This bug was initially created as a clone of Bug #931600 +++

socat has ssl code that uses fixed size 512bit groups:

         dh->p = BN_bin2bn(dh512_p, sizeof(dh512_p), NULL);
         dh->g = BN_bin2bn(dh512_g, sizeof(dh512_g), NULL);
         if ((dh->p == NULL) || (dh->g == NULL)) {
            while (err = ERR_get_error()) {
               Warn1("BN_bin2bn(): %s",
                     ERR_error_string(err, NULL));
            }
            Error("BN_bin2bn() failed");
         } else {
            if (SSL_CTX_set_tmp_dh(*ctx, dh) <= 0) {
               while (err = ERR_get_error()) {
                  Warn3("SSL_CTX_set_tmp_dh(%p, %p): %s", *ctx, dh,
                        ERR_error_string(err, NULL));
               }
               Error2("SSL_CTX_set_tmp_dh(%p, %p) failed", *ctx, dh);
            }
            /*! OPENSSL_free(dh->p,g)? doc does not tell so */
         }
         DH_free(dh);
Comment 1 Swamp Workflow Management 2015-07-21 22:00:12 UTC
bugbot adjusting priority
Comment 2 Sebastian Krahmer 2016-02-03 09:33:00 UTC
IMHO a minor issue, as this fixed 512 bit params are
overriden when dhparam= cmdline is used. The 512bit fixed
seems just a fallback, which only appeared in SLE12.

It could just be removed to have no weak fallback when no
dhparam= cmdline is given. Making VUL-1.
Comment 3 Vítězslav Čížek 2016-02-04 08:25:00 UTC
Upstream advisory:
http://www.dest-unreach.org/socat/contrib/socat-secadv7.html
Comment 4 Peter Simons 2016-02-04 08:27:36 UTC
Upstream increases the DH group size to 1024 in 281d1bd6515c2f0f8984fc168fb3d3b91c20bdc0 to comply to FIPS, then increases to 2048 in eab3c89f2dc0df0d9638941891e8ab233dfb0611 to address socat security advisory 7, MSVR-1499.

The git repository is at git://repo.or.cz/socat.git.
Comment 5 Peter Simons 2016-02-04 09:26:48 UTC
Created attachment 664422 [details]
Defend against pre-computed DH attacks.

This patch increases the size of the DH group used by default to 1024 bits. As  it happens, that particular DH group turned out to be weak in OpenSSL so there is yet another patch following this one that bumps the size to 2048 bits.
Comment 6 Peter Simons 2016-02-04 09:29:28 UTC
Created attachment 664423 [details]
Defend against pre-computed DH attacks.

Use 2048 bit DH group to avoid the weak default in OpenSSL. Addresses MSVR-1499 and improves resilience against logjam.
Comment 10 Bernhard Wiedemann 2016-02-04 15:00:09 UTC
This is an autogenerated message for OBS integration:
This bug (938913) was mentioned in
https://build.opensuse.org/request/show/357738 13.2 / socat
https://build.opensuse.org/request/show/357740 42.1 / socat
Comment 11 Swamp Workflow Management 2016-02-05 12:13:00 UTC
SUSE-SU-2016:0344-1: An update that solves one vulnerability and has one errata is now available.

Category: security (moderate)
Bug References: 938913,964844
CVE References: CVE-2015-4000
Sources used:
SUSE Linux Enterprise Server 12-SP1 (src):    socat-1.7.2.4-3.1
SUSE Linux Enterprise Server 12 (src):    socat-1.7.2.4-3.1
SUSE Linux Enterprise Desktop 12-SP1 (src):    socat-1.7.2.4-3.1
SUSE Linux Enterprise Desktop 12 (src):    socat-1.7.2.4-3.1
Comment 12 Marcus Meissner 2016-02-05 12:36:12 UTC
released
Comment 13 Bernhard Wiedemann 2016-02-08 15:00:09 UTC
This is an autogenerated message for OBS integration:
This bug (938913) was mentioned in
https://build.opensuse.org/request/show/358365 13.2 / socat
https://build.opensuse.org/request/show/358366 42.1 / socat
Comment 14 Swamp Workflow Management 2016-02-16 20:12:56 UTC
openSUSE-SU-2016:0478-1: An update that solves one vulnerability and has one errata is now available.

Category: security (moderate)
Bug References: 938913,964844
CVE References: CVE-2015-4000
Sources used:
openSUSE Leap 42.1 (src):    socat-1.7.3.1-6.1
openSUSE 13.2 (src):    socat-1.7.3.1-2.3.1
Comment 15 Swamp Workflow Management 2016-02-17 00:11:20 UTC
openSUSE-SU-2016:0483-1: An update that solves one vulnerability and has one errata is now available.

Category: security (moderate)
Bug References: 938913,964844
CVE References: CVE-2015-4000
Sources used:
openSUSE 13.1 (src):    socat-1.7.3.1-2.6.1