Bug 964630 - VUL-0: CVE-2013-4148: xen: virtio-net: buffer overflow on invalid state load
VUL-0: CVE-2013-4148: xen: virtio-net: buffer overflow on invalid state load
Classification: Novell Products
Product: SUSE Security Incidents
Classification: Novell Products
Component: Incidents
Other Other
: P3 - Medium : Normal
: ---
Assigned To: Security Team bot
Security Team bot
Depends on:
  Show dependency treegraph
Reported: 2016-02-02 08:58 UTC by Johannes Segitz
Modified: 2016-02-03 12:18 UTC (History)
4 users (show)

See Also:
Found By: Security Response Team
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---


Note You need to log in before you can comment on or make changes to this bug.
Description Johannes Segitz 2016-02-02 08:58:42 UTC
+++ This bug was initially created as a clone of Bug #864812 +++


Michael S. Tsirkin writes:

QEMU 1.0 integer conversion in virtio_net_load()@hw/net/virtio-net.c

>         n->mac_table.in_use = qemu_get_be32(f);

in_use is int so it can get negative when assigned 32bit unsigned value.

>         /* MAC_TABLE_ENTRIES may be different from the saved image */
>         if (n->mac_table.in_use <= MAC_TABLE_ENTRIES) {

passing this check ^^^

>             qemu_get_buffer(f, n->mac_table.macs,
>                             n->mac_table.in_use * ETH_ALEN);

with good in_use value, "n->mac_table.in_use * ETH_ALEN" can get
positive and bigger than mac_table.macs. For example 0x81000000
satisfies this condition when ETH_ALEN is 6.

An user able to alter the savevm data (either on the disk or over the wire
during migration) could use this flaw to to corrupt QEMU process memory on
the (destination) host, which could potentially result in arbitrary code
execution on the host with the privileges of the QEMU process.

Comment 2 Swamp Workflow Management 2016-02-02 23:00:25 UTC
bugbot adjusting priority
Comment 3 Charles Arnold 2016-02-02 23:05:11 UTC
Virtio devices are not supported in Xen so this bug is invalid.
There is no way to define virtio net or block devices for use with Xen.
Comment 4 Johannes Segitz 2016-02-03 12:18:19 UTC
not relevant for our XEN package