Bug 991427 – VUL-0: CVE-2016-6291: php: Out-of-bounds access in exif_process_IFD_in_MAKERNOTE

Bug 991427 - (CVE-2016-6291) VUL-0: CVE-2016-6291: php: Out-of-bounds access in exif_process_IFD_in_MAKERNOTE

(CVE-2016-6291)
Summary:	VUL-0: CVE-2016-6291: php: Out-of-bounds access in exif_process_IFD_in_MAKERNOTE

Status:	RESOLVED FIXED

Classification:	Novell Products
Product:	SUSE Security Incidents
Classification:	Novell Products
Component:	Incidents
Version:	unspecified
Hardware:	Other Other

Priority:	P3 - Medium Severity: Normal
Target Milestone:	---
Assigned To:	Security Team bot
QA Contact:	Security Team bot

URL:	https://smash.suse.de/issue/171312/
Whiteboard:	CVSSv2:SUSE:CVE-2016-6291:5.8:(AV:N/A...
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Create test case

Clone This Bug

Reported:	2016-08-01 08:43 UTC by Sebastian Krahmer
Modified:	2017-09-19 14:35 UTC (History)
CC List:	3 users (show)

See Also:
Found By:	Security Response Team
Services Priority:
Business Priority:
Blocker:	---
Marketing QA Status:	---
IT Deployment:	---

Attachments
CVE-2016-6291.jpg (3.62 KB, application/octet-stream) 2016-08-23 06:34 UTC, Marcus Meissner	Details
CVE-2016-6291.php (73 bytes, text/plain) 2016-08-23 06:38 UTC, Marcus Meissner	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Sebastian Krahmer 2016-08-01 08:43:30 UTC

Quoting from RH BZ:

An out-of-bounds access due to lack of size check of buffer may lead to memory buffer overflow.

rh#1359718

References:
https://bugzilla.redhat.com/show_bug.cgi?id=1359718
http://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2016-6291
http://seclists.org/oss-sec/2016/q3/137
http://people.canonical.com/~ubuntu-security/cve/2016/CVE-2016-6291.html
http://www.debian.org/security/2016/dsa-3631
http://www.cvedetails.com/cve/CVE-2016-6291/

Comment 1 Petr Gajdos 2016-08-02 08:51:58 UTC

Quoting from RH BZ:

An out-of-bounds access due to lack of size check of buffer may lead to memory buffer overflow.

Upstream bug:

https://bugs.php.net/bug.php?id=72603

Upstream patch:

http://git.php.net/?p=php-src.git;a=commit;h=eebcbd5de38a0f1c2876035402cb770e37476519

CVE assignment:

http://seclists.org/oss-sec/2016/q3/137

Comment 2 Petr Gajdos 2016-08-03 08:37:05 UTC

Not sure how to reproduce bug with the testcase in the php bug. Patches applied everywhere, considering affected.

Comment 3 Swamp Workflow Management 2016-08-03 08:57:00 UTC

An update workflow for this issue was started.
This issue was rated as moderate.
Please submit fixed packages until 2016-08-17.
When done, reassign the bug to security-team@suse.de.
https://swamp.suse.de/webswamp/wf/62922

Comment 4 Petr Gajdos 2016-08-04 08:54:26 UTC

I believe all affected code streams fixed.

Comment 5 Bernhard Wiedemann 2016-08-04 10:01:57 UTC

This is an autogenerated message for OBS integration:
This bug (991427) was mentioned in
https://build.opensuse.org/request/show/416889 13.2 / php5

Comment 9 Sebastian Krahmer 2016-08-10 10:01:38 UTC

CVSSv2:SUSE:CVE-2016-6291:5.8:(AV:N/AC:M/Au:N/C:N/I:P/A:P)

Comment 10 Swamp Workflow Management 2016-08-15 13:09:33 UTC

openSUSE-SU-2016:2071-1: An update that fixes 12 vulnerabilities is now available.

Category: security (moderate)
Bug References: 987580,988032,991422,991424,991426,991427,991428,991429,991430,991433,991434,991437
CVE References: CVE-2016-5399,CVE-2016-6128,CVE-2016-6161,CVE-2016-6207,CVE-2016-6288,CVE-2016-6289,CVE-2016-6290,CVE-2016-6291,CVE-2016-6292,CVE-2016-6295,CVE-2016-6296,CVE-2016-6297
Sources used:
openSUSE 13.2 (src):    php5-5.6.1-72.1

Comment 11 Swamp Workflow Management 2016-08-16 11:11:09 UTC

SUSE-SU-2016:2080-1: An update that fixes 12 vulnerabilities is now available.

Category: security (important)
Bug References: 986004,986244,986386,986388,986393,991426,991427,991428,991429,991430,991433,991437
CVE References: CVE-2015-8935,CVE-2016-5399,CVE-2016-5766,CVE-2016-5767,CVE-2016-5769,CVE-2016-5772,CVE-2016-6288,CVE-2016-6289,CVE-2016-6290,CVE-2016-6291,CVE-2016-6296,CVE-2016-6297
Sources used:
SUSE Linux Enterprise Server 11-SP2-LTSS (src):    php5-5.2.14-0.7.30.89.1
SUSE Linux Enterprise Debuginfo 11-SP2 (src):    php5-5.2.14-0.7.30.89.1

Comment 12 Marcus Meissner 2016-08-23 06:34:18 UTC

Created attachment 689043 [details]
CVE-2016-6291.jpg

QA REPRODUCER: 

jpeg file for next comment. CVE-2016-6291.jpg

Comment 13 Marcus Meissner 2016-08-23 06:38:27 UTC

Created attachment 689044 [details]
CVE-2016-6291.php

QA REPRODUCER:

php CVE-2016-6291.jpg


(unclear what bad and good is , the output should change though)

Comment 14 Swamp Workflow Management 2016-09-01 16:10:01 UTC

SUSE-SU-2016:2210-1: An update that fixes 9 vulnerabilities is now available.

Category: security (moderate)
Bug References: 987530,991426,991427,991428,991429,991430,991433,991437
CVE References: CVE-2014-3587,CVE-2016-3587,CVE-2016-5399,CVE-2016-6288,CVE-2016-6289,CVE-2016-6290,CVE-2016-6291,CVE-2016-6296,CVE-2016-6297
Sources used:
SUSE Linux Enterprise Software Development Kit 11-SP4 (src):    php53-5.3.17-79.2
SUSE Linux Enterprise Server 11-SP4 (src):    php53-5.3.17-79.2
SUSE Linux Enterprise Debuginfo 11-SP4 (src):    php53-5.3.17-79.2

Comment 16 Konstantinos Tsamis 2016-09-16 13:50:00 UTC

Using the attached reproducer with the attached jpeg I get the below output:

Before:
~~~~~~~


d21:/tmp/kostas # php 991427.php
PHP Warning:  exif_read_data(CVE-2016-6291.jpg): Illegal IFD offset in /tmp/kostas/991427.php on line 2
array(16) {
  ["FileName"]=>
  string(17) "CVE-2016-6291.jpg"
  ["FileDateTime"]=>
  int(1473934530)
  ["FileSize"]=>
  int(3711)
  ["FileType"]=>
  int(2)
  ["MimeType"]=>
  string(10) "image/jpeg"
  ["SectionsFound"]=>
  string(30) "ANY_TAG, IFD0, EXIF, MAKERNOTE"
  ["COMPUTED"]=>
  array(8) {
    ["IsColor"]=>
    int(0)
    ["ByteOrderMotorola"]=>
    int(0)
    ["ApertureFNumber"]=>
    string(5) "f/1.0"
    ["UserComment"]=>
    string(80) "????????????????????????????????????????????????????????????????????????????????"
    ["UserCommentEncoding"]=>
    string(7) "UNICODE"
    ["Copyright"]=>
    string(45) "FFFFFFFFFFFFF, DDDDDDDDDDDDDDDDDDDDDDDDDDDDDD"
    ["Copyright.Photographer"]=>
    string(13) "FFFFFFFFFFFFF"
    ["Copyright.Editor"]=>
    string(30) "DDDDDDDDDDDDDDDDDDDDDDDDDDDDDD"
  }
  ["XResolution"]=>
  string(21) "1414812756/1414812756"
  ["ExposureTime"]=>
  string(21) "1414812756/1414812756"
  ["FNumber"]=>
  string(21) "1414812756/1414812756"
  ["UserComment"]=>
  string(7) "UNICODE"
  ["Copyright"]=>
  string(13) "FFFFFFFFFFFFF"
  ["Make"]=>
  string(5) "Canon"
  ["MakerNote"]=>
  array(7) {
    [0]=>
    int(34078722)
    [1]=>
    int(65538)
    [2]=>
    int(-91095040)
    [3]=>
    int(-1836646401)
    [4]=>
    int(16711682)
    [5]=>
    int(0)
    [6]=>
    int(1381105664)
  }
  ["UndefinedTag:0x0208"]=>
  string(1) "ï¿½"
  ["UndefinedTag:0x9286"]=>
  string(12) "ExposureTime"
}







After:
~~~~~~


d21:/tmp/kostas # php 991427.php
PHP Warning:  exif_read_data(CVE-2016-6291.jpg): IFD data bad offset: 0x058C length 0x001C in /tmp/kostas/991427.php on line 2
array(13) {
  ["FileName"]=>
  string(17) "CVE-2016-6291.jpg"
  ["FileDateTime"]=>
  int(1473934530)
  ["FileSize"]=>
  int(3711)
  ["FileType"]=>
  int(2)
  ["MimeType"]=>
  string(10) "image/jpeg"
  ["SectionsFound"]=>
  string(30) "ANY_TAG, IFD0, EXIF, MAKERNOTE"
  ["COMPUTED"]=>
  array(8) {
    ["IsColor"]=>
    int(0)
    ["ByteOrderMotorola"]=>
    int(0)
    ["ApertureFNumber"]=>
    string(5) "f/1.0"
    ["UserComment"]=>
    string(80) "????????????????????????????????????????????????????????????????????????????????"
    ["UserCommentEncoding"]=>
    string(7) "UNICODE"
    ["Copyright"]=>
    string(45) "FFFFFFFFFFFFF, DDDDDDDDDDDDDDDDDDDDDDDDDDDDDD"
    ["Copyright.Photographer"]=>
    string(13) "FFFFFFFFFFFFF"
    ["Copyright.Editor"]=>
    string(30) "DDDDDDDDDDDDDDDDDDDDDDDDDDDDDD"
  }
  ["XResolution"]=>
  string(21) "1414812756/1414812756"
  ["ExposureTime"]=>
  string(21) "1414812756/1414812756"
  ["FNumber"]=>
  string(21) "1414812756/1414812756"
  ["UserComment"]=>
  string(7) "UNICODE"
  ["Copyright"]=>
  string(13) "FFFFFFFFFFFFF"
  ["Make"]=>
  string(5) "Canon"
}



Running the testsuite I had a regression that showed this test failing after: PHPTEST2061

PHPTEST2061:

	Before:
	~~~~~~~
		s390vsw116:/usr/share/qa/qa_test_php53/ext/exif/tests # ./bug54002.sh

		Warning: exif_read_data(bug54002_1.jpeg): Process tag(x0205=UndefinedTa): Illegal byte_count in /usr/share/qa/qa_test_php53/ext/exif/tests/bug54002.php on line 2
		Warning: exif_read_data(bug54002_1.jpeg): Process tag(xA000=FlashPixVer): Illegal pointer offset(x30303130 + x0044 = x30303174 > x1BF5) in /usr/share/qa/qa_test_php53/ext/exif/tests/bug54002.php on line 2       
		Warning: exif_read_data(bug54002_2.jpeg): Process tag(x0205=UndefinedTa): Illegal byte_count in /usr/share/qa/qa_test_php53/ext/exif/tests/bug54002.php on line 3
		Warning: exif_read_data(bug54002_2.jpeg): Process tag(xA000=FlashPixVer): Illegal pointer offset(x30303130 + x0044 = x30303174 > x1BF5) in /usr/share/qa/qa_test_php53/ext/exif/tests/bug54002.php on line 3

	After:
	~~~~~~

		s390vsw116:/usr/share/qa/qa_test_php53/ext/exif/tests # ./bug54002.sh

		Warning: exif_read_data(bug54002_1.jpeg): Process tag(x0205=UndefinedTa): Illegal byte_count in /usr/share/qa/qa_test_php53/ext/exif/tests/bug54002.php on line 2

		Warning: exif_read_data(bug54002_2.jpeg): Process tag(x0205=UndefinedTa): Illegal byte_count in /usr/share/qa/qa_test_php53/ext/exif/tests/bug54002.php on line 3


The test's src code is:


s390vsw116:/tmp/kostas # cat /usr/share/qa/qa_test_php53/ext/exif/tests/bug54002.php
<?php
exif_read_data(__DIR__ . '/bug54002_1.jpeg');
exif_read_data(__DIR__ . '/bug54002_2.jpeg');

?>


My question is: Are the results I have an improvement? And if so why do I get the Illegal byte_count warning still? Is this a new bug? Basically I think that there is an improvement since from 4 warnings we go to 2, but why are there still 2?

The update with this patch is released today.
I am not making the comment private since this is released, let me know if I should.

Comment 17 Swamp Workflow Management 2016-09-16 19:09:45 UTC

SUSE-SU-2016:2328-1: An update that fixes 18 vulnerabilities is now available.

Category: security (important)
Bug References: 987530,991426,991427,991428,991429,991430,991433,991437,997206,997207,997208,997210,997211,997220,997225,997230,997257
CVE References: CVE-2014-3587,CVE-2016-3587,CVE-2016-5399,CVE-2016-6288,CVE-2016-6289,CVE-2016-6290,CVE-2016-6291,CVE-2016-6296,CVE-2016-6297,CVE-2016-7124,CVE-2016-7125,CVE-2016-7126,CVE-2016-7127,CVE-2016-7128,CVE-2016-7129,CVE-2016-7130,CVE-2016-7131,CVE-2016-7132
Sources used:
SUSE Linux Enterprise Server 11-SP2-LTSS (src):    php53-5.3.17-55.1
SUSE Linux Enterprise Debuginfo 11-SP2 (src):    php53-5.3.17-55.1

Comment 18 Swamp Workflow Management 2016-09-28 13:10:57 UTC

SUSE-SU-2016:2408-1: An update that fixes 24 vulnerabilities is now available.

Category: security (important)
Bug References: 987530,987580,988032,991422,991424,991426,991427,991428,991429,991430,991433,991434,991437,997206,997207,997208,997210,997211,997220,997225,997230,997248,997257
CVE References: CVE-2014-3587,CVE-2016-3587,CVE-2016-5399,CVE-2016-6128,CVE-2016-6161,CVE-2016-6207,CVE-2016-6288,CVE-2016-6289,CVE-2016-6290,CVE-2016-6291,CVE-2016-6292,CVE-2016-6295,CVE-2016-6296,CVE-2016-6297,CVE-2016-7124,CVE-2016-7125,CVE-2016-7126,CVE-2016-7127,CVE-2016-7128,CVE-2016-7129,CVE-2016-7130,CVE-2016-7131,CVE-2016-7132,CVE-2016-7134
Sources used:
SUSE Linux Enterprise Software Development Kit 12-SP1 (src):    php5-5.5.14-73.1
SUSE Linux Enterprise Module for Web Scripting 12 (src):    php5-5.5.14-73.1

Comment 19 Swamp Workflow Management 2016-10-04 15:12:17 UTC

openSUSE-SU-2016:2451-1: An update that fixes 24 vulnerabilities is now available.

Category: security (important)
Bug References: 987530,987580,988032,991422,991424,991426,991427,991428,991429,991430,991433,991434,991437,997206,997207,997208,997210,997211,997220,997225,997230,997248,997257
CVE References: CVE-2014-3587,CVE-2016-3587,CVE-2016-5399,CVE-2016-6128,CVE-2016-6161,CVE-2016-6207,CVE-2016-6288,CVE-2016-6289,CVE-2016-6290,CVE-2016-6291,CVE-2016-6292,CVE-2016-6295,CVE-2016-6296,CVE-2016-6297,CVE-2016-7124,CVE-2016-7125,CVE-2016-7126,CVE-2016-7127,CVE-2016-7128,CVE-2016-7129,CVE-2016-7130,CVE-2016-7131,CVE-2016-7132,CVE-2016-7134
Sources used:
openSUSE Leap 42.1 (src):    php5-5.5.14-59.1

Comment 20 Swamp Workflow Management 2016-10-05 19:09:54 UTC

SUSE-SU-2016:2460-1: An update that solves 29 vulnerabilities and has two fixes is now available.

Category: security (important)
Bug References: 1001950,987580,988032,991422,991424,991426,991427,991428,991429,991430,991434,991437,995512,997206,997207,997208,997210,997211,997220,997225,997230,997247,997248,997257,999313,999679,999680,999684,999685,999819,999820
CVE References: CVE-2016-4473,CVE-2016-5399,CVE-2016-6128,CVE-2016-6161,CVE-2016-6207,CVE-2016-6289,CVE-2016-6290,CVE-2016-6291,CVE-2016-6292,CVE-2016-6295,CVE-2016-6296,CVE-2016-6297,CVE-2016-7124,CVE-2016-7125,CVE-2016-7126,CVE-2016-7127,CVE-2016-7128,CVE-2016-7129,CVE-2016-7130,CVE-2016-7131,CVE-2016-7132,CVE-2016-7133,CVE-2016-7134,CVE-2016-7412,CVE-2016-7413,CVE-2016-7414,CVE-2016-7416,CVE-2016-7417,CVE-2016-7418
Sources used:
SUSE Linux Enterprise Software Development Kit 12-SP1 (src):    php7-7.0.7-15.1
SUSE Linux Enterprise Module for Web Scripting 12 (src):    php7-7.0.7-15.1

Comment 21 Marcus Meissner 2016-10-31 08:13:58 UTC

released

Comment 22 Swamp Workflow Management 2016-11-01 15:22:41 UTC

SUSE-SU-2016:2460-2: An update that solves 29 vulnerabilities and has two fixes is now available.

Category: security (important)
Bug References: 1001950,987580,988032,991422,991424,991426,991427,991428,991429,991430,991434,991437,995512,997206,997207,997208,997210,997211,997220,997225,997230,997247,997248,997257,999313,999679,999680,999684,999685,999819,999820
CVE References: CVE-2016-4473,CVE-2016-5399,CVE-2016-6128,CVE-2016-6161,CVE-2016-6207,CVE-2016-6289,CVE-2016-6290,CVE-2016-6291,CVE-2016-6292,CVE-2016-6295,CVE-2016-6296,CVE-2016-6297,CVE-2016-7124,CVE-2016-7125,CVE-2016-7126,CVE-2016-7127,CVE-2016-7128,CVE-2016-7129,CVE-2016-7130,CVE-2016-7131,CVE-2016-7132,CVE-2016-7133,CVE-2016-7134,CVE-2016-7412,CVE-2016-7413,CVE-2016-7414,CVE-2016-7416,CVE-2016-7417,CVE-2016-7418
Sources used:
SUSE Linux Enterprise Module for Web Scripting 12 (src):    php7-7.0.7-15.1

Comment 23 Swamp Workflow Management 2017-01-30 13:29:54 UTC

An update workflow for this issue was started.
This issue was rated as moderate.
Please submit fixed packages until 2017-02-13.
When done, reassign the bug to security-team@suse.de.
https://swamp.suse.de/webswamp/wf/63367