Bug 1095219 - (CVE-2018-11235) VUL-0: CVE-2018-11235: git,libgit2: arbitrary code execution when recursively cloning a malicious repository
(CVE-2018-11235)
VUL-0: CVE-2018-11235: git,libgit2: arbitrary code execution when recursively...
Status: RESOLVED FIXED
Classification: Novell Products
Product: SUSE Security Incidents
Classification: Novell Products
Component: Incidents
unspecified
Other Other
: P3 - Medium : Major
: ---
Assigned To: Security Team bot
Security Team bot
https://smash.suse.de/issue/206663/
CVSSv3:RedHat:CVE-2018-11235:8.8:(AV:...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2018-05-30 13:34 UTC by Victor Pereira
Modified: 2020-05-01 22:27 UTC (History)
9 users (show)

See Also:
Found By: Security Response Team
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Victor Pereira 2018-05-30 13:34:13 UTC
rh#1583862

In Git before 2.13.7, 2.14.x before 2.14.4, 2.15.x before 2.15.2, 2.16.x before
2.16.4, and 2.17.x before 2.17.1, remote code execution can occur. With a
crafted .gitmodules file, a malicious project can execute an arbitrary script on
a machine that runs "git clone --recurse-submodules" because submodule "names"
are obtained from this file, and then appended to $GIT_DIR/modules, leading to
directory traversal with "../" in a name. Finally, post-checkout hooks from a
submodule are executed, bypassing the intended design in which hooks are not
obtained from a remote server.

References:
https://bugzilla.redhat.com/show_bug.cgi?id=1583862
http://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2018-11235
http://people.canonical.com/~ubuntu-security/cve/2018/CVE-2018-11235.html
http://www.debian.org/security/2018/dsa-4212
https://blogs.msdn.microsoft.com/devops/2018/05/29/announcing-the-may-2018-git-security-vulnerability/
Comment 1 Takashi Iwai 2018-05-30 14:46:12 UTC
FACTORY was already updated to 2.17.1.

SLE15 / Leap 15.0 will be fixed via the update to 2.16.4. MR#165936
Leap 42.3 will be fixed via the update to 2.13.7.  MR#613089

SLE12 and older need manual backports.  Working on them.
Comment 3 Swamp Workflow Management 2018-05-30 15:40:10 UTC
This is an autogenerated message for OBS integration:
This bug (1095219) was mentioned in
https://build.opensuse.org/request/show/613089 42.3 / git
https://build.opensuse.org/request/show/613093 Factory / git
Comment 4 Takashi Iwai 2018-05-30 15:47:45 UTC
SLE12 -> MR#165944
Comment 6 Swamp Workflow Management 2018-05-30 17:10:10 UTC
This is an autogenerated message for OBS integration:
This bug (1095219) was mentioned in
https://build.opensuse.org/request/show/613100 15.0 / git
Comment 7 Swamp Workflow Management 2018-06-06 01:07:29 UTC
openSUSE-SU-2018:1553-1: An update that fixes two vulnerabilities is now available.

Category: security (important)
Bug References: 1095218,1095219
CVE References: CVE-2018-11233,CVE-2018-11235
Sources used:
openSUSE Leap 42.3 (src):    git-2.13.7-13.1
openSUSE Leap 15.0 (src):    git-2.16.4-lp150.2.3.1
Comment 8 Swamp Workflow Management 2018-06-07 13:08:54 UTC
SUSE-SU-2018:1566-1: An update that fixes two vulnerabilities is now available.

Category: security (important)
Bug References: 1095218,1095219
CVE References: CVE-2018-11233,CVE-2018-11235
Sources used:
SUSE OpenStack Cloud 8 (src):    git-2.12.3-27.14.1
SUSE OpenStack Cloud 7 (src):    git-2.12.3-27.14.1
SUSE Linux Enterprise Software Development Kit 12-SP3 (src):    git-2.12.3-27.14.1
SUSE Linux Enterprise Server for SAP 12-SP2 (src):    git-2.12.3-27.14.1
SUSE Linux Enterprise Server for SAP 12-SP1 (src):    git-2.12.3-27.14.1
SUSE Linux Enterprise Server 12-SP3 (src):    git-2.12.3-27.14.1
SUSE Linux Enterprise Server 12-SP2-LTSS (src):    git-2.12.3-27.14.1
SUSE Linux Enterprise Server 12-SP1-LTSS (src):    git-2.12.3-27.14.1
SUSE Linux Enterprise Server 12-LTSS (src):    git-2.12.3-27.14.1
SUSE Enterprise Storage 4 (src):    git-2.12.3-27.14.1
SUSE CaaS Platform ALL (src):    git-2.12.3-27.14.1
OpenStack Cloud Magnum Orchestration 7 (src):    git-2.12.3-27.14.1
HPE Helion OpenStack 8 (src):    git-2.12.3-27.14.1
Comment 9 Takashi Iwai 2018-06-07 14:38:08 UTC
For SLE11 and older, it's very tough to backport these fixes, as the code base has been changed too much.

So I concluded that it's rather too risky to backport them forcibly, and leave them.

Back to security team.
Comment 10 Swamp Workflow Management 2018-07-03 22:09:01 UTC
SUSE-SU-2018:1872-1: An update that fixes two vulnerabilities is now available.

Category: security (important)
Bug References: 1095218,1095219
CVE References: CVE-2018-11233,CVE-2018-11235
Sources used:
SUSE Linux Enterprise Module for Development Tools 15 (src):    git-2.16.4-3.3.2
SUSE Linux Enterprise Module for Basesystem 15 (src):    git-2.16.4-3.3.2
Comment 12 Andreas Stieger 2018-07-11 07:10:00 UTC
https://build.opensuse.org/request/show/621935
Comment 16 Swamp Workflow Management 2018-08-21 16:09:12 UTC
SUSE-SU-2018:2469-1: An update that fixes four vulnerabilities is now available.

Category: security (important)
Bug References: 1095219,1100612,1100613,1104641
CVE References: CVE-2018-10887,CVE-2018-10888,CVE-2018-11235,CVE-2018-15501
Sources used:
SUSE Linux Enterprise Module for Development Tools 15 (src):    libgit2-0.26.6-3.5.2
Comment 17 Swamp Workflow Management 2018-08-24 22:08:04 UTC
openSUSE-SU-2018:2502-1: An update that fixes four vulnerabilities is now available.

Category: security (important)
Bug References: 1095219,1100612,1100613,1104641
CVE References: CVE-2018-10887,CVE-2018-10888,CVE-2018-11235,CVE-2018-15501
Sources used:
openSUSE Leap 15.0 (src):    libgit2-0.26.6-lp150.2.3.1
Comment 22 Swamp Workflow Management 2018-10-18 17:06:31 UTC
SUSE-SU-2018:1566-2: An update that fixes two vulnerabilities is now available.

Category: security (important)
Bug References: 1095218,1095219
CVE References: CVE-2018-11233,CVE-2018-11235
Sources used:
SUSE Linux Enterprise Server 12-SP2-BCL (src):    git-2.12.3-27.14.1
Comment 23 Swamp Workflow Management 2018-10-25 16:13:14 UTC
SUSE-SU-2018:3440-1: An update that fixes 5 vulnerabilities is now available.

Category: security (moderate)
Bug References: 1085256,1095219,1100612,1100613,1104641
CVE References: CVE-2018-10887,CVE-2018-10888,CVE-2018-11235,CVE-2018-15501,CVE-2018-8099
Sources used:
SUSE Manager Server 3.2 (src):    libgit2-0.24.1-7.6.1
SUSE Manager Server 3.1 (src):    libgit2-0.24.1-7.6.1
SUSE Linux Enterprise Software Development Kit 12-SP3 (src):    libgit2-0.24.1-7.6.1
Comment 24 Swamp Workflow Management 2018-10-26 22:24:39 UTC
openSUSE-SU-2018:3519-1: An update that fixes 5 vulnerabilities is now available.

Category: security (moderate)
Bug References: 1085256,1095219,1100612,1100613,1104641
CVE References: CVE-2018-10887,CVE-2018-10888,CVE-2018-11235,CVE-2018-15501,CVE-2018-8099
Sources used:
openSUSE Leap 42.3 (src):    libgit2-0.24.1-10.3.1
Comment 25 Takashi Iwai 2018-10-31 11:34:20 UTC
Reassigned to the new git package maintainer.
Comment 27 Markéta Machová 2018-11-07 13:00:45 UTC
I somehow managed to apply these patches also to SLE11:
SLE11-SP1 -> https://build.suse.de/request/show/176926
Comment 28 Markéta Machová 2018-11-07 13:56:29 UTC
The git-1.6.0.2 in SLE-11_Update differs so much from git-1.7.12.4 in SLE-11-SP1_Update that I have serious troubles with applying the patches (for example, there is no ntfs or hfs support). I would be able to apply only some of the patches, and since the two CVE's vere closely connected, I am afraid that the fix will not be complete. Is this serious problem?
Comment 29 Markéta Machová 2018-11-12 09:46:50 UTC
I got this bug also (at least partially) fixed on SLE11_Update. The removed commits were fixing another bug which does not affect such old version. The one fix I am puzzled about is not testing if we skip the worktree, but it looks like
the code does not skip worktrees at all.

https://build.suse.de/request/show/177251

Back to security team.
Comment 41 Alexandros Toptsoglou 2020-04-24 15:08:46 UTC
Done
Comment 42 Swamp Workflow Management 2020-04-28 10:36:06 UTC
SUSE-SU-2020:1121-1: An update that solves 15 vulnerabilities and has 8 fixes is now available.

Category: security (moderate)
Bug References: 1063412,1095218,1095219,1110949,1112230,1114225,1132350,1149792,1156651,1158785,1158787,1158788,1158789,1158790,1158791,1158792,1158793,1158795,1167890,1168930,1169605,1169786,1169936
CVE References: CVE-2017-15298,CVE-2018-11233,CVE-2018-11235,CVE-2018-17456,CVE-2019-1348,CVE-2019-1349,CVE-2019-1350,CVE-2019-1351,CVE-2019-1352,CVE-2019-1353,CVE-2019-1354,CVE-2019-1387,CVE-2019-19604,CVE-2020-11008,CVE-2020-5260
Sources used:
SUSE Linux Enterprise Module for Open Buildservice Development Tools 15-SP1 (src):    git-2.26.1-3.25.2
SUSE Linux Enterprise Module for Development Tools 15-SP1 (src):    git-2.26.1-3.25.2
SUSE Linux Enterprise Module for Basesystem 15-SP1 (src):    git-2.26.1-3.25.2

NOTE: This line indicates an update has been released for the listed product(s). At times this might be only a partial fix. If you have questions please reach out to maintenance coordination.
Comment 43 Swamp Workflow Management 2020-05-01 22:27:04 UTC
openSUSE-SU-2020:0598-1: An update that solves 15 vulnerabilities and has 8 fixes is now available.

Category: security (moderate)
Bug References: 1063412,1095218,1095219,1110949,1112230,1114225,1132350,1149792,1156651,1158785,1158787,1158788,1158789,1158790,1158791,1158792,1158793,1158795,1167890,1168930,1169605,1169786,1169936
CVE References: CVE-2017-15298,CVE-2018-11233,CVE-2018-11235,CVE-2018-17456,CVE-2019-1348,CVE-2019-1349,CVE-2019-1350,CVE-2019-1351,CVE-2019-1352,CVE-2019-1353,CVE-2019-1354,CVE-2019-1387,CVE-2019-19604,CVE-2020-11008,CVE-2020-5260
Sources used:
openSUSE Leap 15.1 (src):    git-2.26.1-lp151.4.9.1