Bug 1166457 - (CVE-2020-10108) VUL-0: CVE-2020-10108: python-Twisted: requests with multiple Content-Length headers were allowed
(CVE-2020-10108)
VUL-0: CVE-2020-10108: python-Twisted: requests with multiple Content-Length ...
Status: RESOLVED FIXED
Classification: Novell Products
Product: SUSE Security Incidents
Classification: Novell Products
Component: Incidents
unspecified
Other Other
: P3 - Medium : Normal
: ---
Assigned To: Security Team bot
Security Team bot
https://smash.suse.de/issue/254657/
CVSSv3.1:SUSE:CVE-2020-10108:7.5:(AV...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2020-03-12 09:15 UTC by Wolfgang Frisch
Modified: 2022-08-25 14:43 UTC (History)
6 users (show)

See Also:
Found By: Security Response Team
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---


Attachments
twisted-web-helloworld.py (499 bytes, text/x-python)
2020-03-12 09:55 UTC, Wolfgang Frisch
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Wolfgang Frisch 2020-03-12 09:15:26 UTC
CVE-2020-10108

An HTTP request smuggling issue was found in python-Twisted. Requests with multiple Content-Length headers were allowed.

References:
http://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2020-10108
https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2020-10108
http://people.canonical.com/~ubuntu-security/cve/2020/CVE-2020-10108.html
Comment 1 Wolfgang Frisch 2020-03-12 09:26:07 UTC
SUSE:SLE-12:Update   python-Twisted   Affected
SUSE:SLE-15:Update   python-Twisted   Affected
Comment 2 Wolfgang Frisch 2020-03-12 09:55:04 UTC
Created attachment 832616 [details]
twisted-web-helloworld.py

Minimal Twisted web server
Comment 3 Wolfgang Frisch 2020-03-12 09:57:06 UTC
QA REPRODUCER:

# python3 twisted-web-helloworld.py
# printf "GET / HTTP/1.1\r\nContent-Length: 3\r\nContent-Length: 0\r\nUser-Agent: nc/0.0.1\r\nHost: 127.0.0.1\r\nAccept: */*\r\n\r\n---" | nc 127.0.0.1 8080

Result GOOD:
> HTTP/1.1 400 Bad Request

Result FAIL: 
> HTTP/1.1 200 OK
> Server: TwistedWeb/19.10.0
> Date: Thu, 12 Mar 2020 09:49:03 GMT
> Content-Type: text/plain
> Content-Length: 13
> 
> Hello, World.
Comment 5 Matej Cepl 2022-08-02 08:53:54 UTC
According to rh#1813439 the solution is in https://github.com/twisted/twisted/commit/4a7d22e490bb8ff836892cc99a1f54b85ccb0281
Comment 6 Gianluca Gabrielli 2022-08-02 11:29:24 UTC
please submit it together with bsc#1166458
Comment 7 Matej Cepl 2022-08-02 12:00:28 UTC
(In reply to Wolfgang Frisch from comment #1)
> SUSE:SLE-15:Update   python-Twisted   Affected

Are you sure? According to the CVE report, this bug has been fixed in 19.10.0, which is exactly what we have in SLE-15-SP2 and in SLE-15-SP4 we have even 22.2.0.
Comment 9 Gianluca Gabrielli 2022-08-02 14:07:54 UTC
(In reply to Matej Cepl from comment #7)
> (In reply to Wolfgang Frisch from comment #1)
> > SUSE:SLE-15:Update   python-Twisted   Affected
> 
> Are you sure? According to the CVE report, this bug has been fixed in
> 19.10.0, which is exactly what we have in SLE-15-SP2 and in SLE-15-SP4 we
> have even 22.2.0.

I guess is the same as for bsc#1166458.c8, from the github link you shared in comment 5 you can see which are the tags that contains that comment, and the oldest one is 20.3.0
Comment 10 Gianluca Gabrielli 2022-08-03 09:11:05 UTC
CVE-2020-10108 is not mentioned in 15-SP2 changes file
Comment 11 Swamp Workflow Management 2022-08-16 13:16:34 UTC
SUSE-SU-2022:2811-1: An update that fixes two vulnerabilities is now available.

Category: security (important)
Bug References: 1166457,1166458
CVE References: CVE-2020-10108,CVE-2020-10109
JIRA References: 
Sources used:
SUSE OpenStack Cloud Crowbar 9 (src):    python-Twisted-15.2.1-9.20.1
SUSE OpenStack Cloud Crowbar 8 (src):    python-Twisted-15.2.1-9.20.1
SUSE OpenStack Cloud 9 (src):    python-Twisted-15.2.1-9.20.1
SUSE OpenStack Cloud 8 (src):    python-Twisted-15.2.1-9.20.1
SUSE Linux Enterprise Module for Web Scripting 12 (src):    python-Twisted-15.2.1-9.20.1
HPE Helion Openstack 8 (src):    python-Twisted-15.2.1-9.20.1

NOTE: This line indicates an update has been released for the listed product(s). At times this might be only a partial fix. If you have questions please reach out to maintenance coordination.
Comment 12 Alexander Bergmann 2022-08-25 14:43:29 UTC
I've double checked this issue again and it looks like this is fixed. The following two patches have mostly the same content.

SUSE:SLE-12:Update/python-Twisted/CVE-2020-10108-http-req-headers.patch 
SUSE:SLE-15-SP2:Update/python-Twisted/CVE-2022-24801-http-1.1-leniency.patch 


Setting this issue to resolved.