Bugzilla – Bug 1174908
VUL-0: CVE-2020-14360: xorg-x11-server: XkbSetMap Out-Of-Bounds Access Privilege Escalation Vulnerability (ZDI-CAN-11572)
Last modified: 2020-12-10 14:04:27 UTC
Ok. Thanks!
Any news on this one?
Created attachment 843565 [details] CVE-2020-14360.patch Avoid out of bounds memory accesses on too short request. ZDI-CAN 11572 / CVE-2020-14360 This vulnerability was discovered by: Jan-Niklas Sohn working with Trend Micro Zero Day Initiative Signed-off-by: Matthieu Herrb <matthieu@herrb.eu>
[ 61s] xkb.c: In function 'ProcXkbSetMap': [ 61s] xkb.c:2430:27: warning: 'keytype' may be used uninitialized in this function [-Wmaybe-uninitialized] [ 61s] nSyms = symmap->nSyms; [ 61s] ~~~~~~^~~~~~~ [ 61s] xkb.c:2389:25: note: 'keytype' was declared here [ 61s] xkbKeyTypeWireDesc *keytype; This appears to me to be an issue with the patch. If if (req->present & XkbKeyTypesMask) does not apply indeed later keytype will remain undefined. Could you verify this, please? If needed with the author. Thanks!
Created attachment 843719 [details] patchv2 While the multiplications cannot overflow, I think it is possible to try to overflow the total length, since there can be up to 65536*65536 nested structures in the 'syms' list. This is very unlikely to be practically doable, since it means transmitting almost UINT32_MAX bytes of data. The following new version of the patch checks at each step that the total length is not overflowing UINT32_MAX.
Hmm. Maybe I'm blind and/or stupid, but I don't see my issue addressed with that patch. keytype may still be undefined. Could you double check or try to explain?
I see. Just double checked with the updated patch for sure. Still the same issue. [ 59s] xkb.c: In function 'ProcXkbSetMap': [ 59s] xkb.c:2427:27: warning: 'keytype' may be used uninitialized in this function [-Wmaybe-uninitialized] [ 59s] nSyms = symmap->nSyms; [ 59s] ~~~~~~^~~~~~~ [ 59s] xkb.c:2393:25: note: 'keytype' was declared here [ 59s] xkbKeyTypeWireDesc *keytype;
Thanks a lot. Patch is now warning-free and makes sense to me. I just submitted the packages.
now public through oss * CVE-2020-14360 / ZDI CAN 11572 XkbSetMap Out-Of-Bounds Access Insufficient checks on the lengths of the XkbSetMap request can lead to out of bounds memory accesses in the X server.
Just submitted to factory/TW. Reassigning.
This is an autogenerated message for OBS integration: This bug (1174908) was mentioned in https://build.opensuse.org/request/show/852408 Factory / xorg-x11-server
SUSE-SU-2020:3588-1: An update that fixes two vulnerabilities is now available. Category: security (important) Bug References: 1174908,1177596 CVE References: CVE-2020-14360,CVE-2020-25712 JIRA References: Sources used: SUSE Linux Enterprise Workstation Extension 15-SP2 (src): xorg-x11-server-1.20.3-22.5.16.1 SUSE Linux Enterprise Module for Development Tools 15-SP2 (src): xorg-x11-server-1.20.3-22.5.16.1 SUSE Linux Enterprise Module for Basesystem 15-SP2 (src): xorg-x11-server-1.20.3-22.5.16.1 NOTE: This line indicates an update has been released for the listed product(s). At times this might be only a partial fix. If you have questions please reach out to maintenance coordination.
SUSE-SU-2020:3589-1: An update that fixes two vulnerabilities is now available. Category: security (important) Bug References: 1174908,1177596 CVE References: CVE-2020-14360,CVE-2020-25712 JIRA References: Sources used: SUSE Linux Enterprise Server for SAP 15 (src): xorg-x11-server-1.19.6-8.27.1 SUSE Linux Enterprise Server 15-LTSS (src): xorg-x11-server-1.19.6-8.27.1 SUSE Linux Enterprise High Performance Computing 15-LTSS (src): xorg-x11-server-1.19.6-8.27.1 SUSE Linux Enterprise High Performance Computing 15-ESPOS (src): xorg-x11-server-1.19.6-8.27.1 NOTE: This line indicates an update has been released for the listed product(s). At times this might be only a partial fix. If you have questions please reach out to maintenance coordination.
SUSE-SU-2020:3582-1: An update that fixes two vulnerabilities is now available. Category: security (important) Bug References: 1174908,1177596 CVE References: CVE-2020-14360,CVE-2020-25712 JIRA References: Sources used: SUSE OpenStack Cloud Crowbar 9 (src): xorg-x11-server-1.19.6-4.19.1 SUSE OpenStack Cloud 9 (src): xorg-x11-server-1.19.6-4.19.1 SUSE Linux Enterprise Server for SAP 12-SP4 (src): xorg-x11-server-1.19.6-4.19.1 SUSE Linux Enterprise Server 12-SP4-LTSS (src): xorg-x11-server-1.19.6-4.19.1 NOTE: This line indicates an update has been released for the listed product(s). At times this might be only a partial fix. If you have questions please reach out to maintenance coordination.
SUSE-SU-2020:3587-1: An update that fixes two vulnerabilities is now available. Category: security (important) Bug References: 1174908,1177596 CVE References: CVE-2020-14360,CVE-2020-25712 JIRA References: Sources used: SUSE Linux Enterprise Software Development Kit 12-SP5 (src): xorg-x11-server-1.19.6-10.20.1 SUSE Linux Enterprise Server 12-SP5 (src): xorg-x11-server-1.19.6-10.20.1 NOTE: This line indicates an update has been released for the listed product(s). At times this might be only a partial fix. If you have questions please reach out to maintenance coordination.
SUSE-SU-2020:3586-1: An update that fixes two vulnerabilities is now available. Category: security (important) Bug References: 1174908,1177596 CVE References: CVE-2020-14360,CVE-2020-25712 JIRA References: Sources used: SUSE Linux Enterprise Workstation Extension 15-SP1 (src): xorg-x11-server-1.20.3-14.5.13.1 SUSE Linux Enterprise Module for Development Tools 15-SP1 (src): xorg-x11-server-1.20.3-14.5.13.1 SUSE Linux Enterprise Module for Basesystem 15-SP1 (src): xorg-x11-server-1.20.3-14.5.13.1 NOTE: This line indicates an update has been released for the listed product(s). At times this might be only a partial fix. If you have questions please reach out to maintenance coordination.
SUSE-SU-2020:3585-1: An update that fixes two vulnerabilities is now available. Category: security (important) Bug References: 1174908,1177596 CVE References: CVE-2020-14360,CVE-2020-25712 JIRA References: Sources used: SUSE OpenStack Cloud Crowbar 8 (src): xorg-x11-server-7.6_1.18.3-76.37.1 SUSE OpenStack Cloud 8 (src): xorg-x11-server-7.6_1.18.3-76.37.1 SUSE OpenStack Cloud 7 (src): xorg-x11-server-7.6_1.18.3-76.37.1 SUSE Linux Enterprise Server for SAP 12-SP3 (src): xorg-x11-server-7.6_1.18.3-76.37.1 SUSE Linux Enterprise Server for SAP 12-SP2 (src): xorg-x11-server-7.6_1.18.3-76.37.1 SUSE Linux Enterprise Server 12-SP3-LTSS (src): xorg-x11-server-7.6_1.18.3-76.37.1 SUSE Linux Enterprise Server 12-SP3-BCL (src): xorg-x11-server-7.6_1.18.3-76.37.1 SUSE Linux Enterprise Server 12-SP2-LTSS (src): xorg-x11-server-7.6_1.18.3-76.37.1 SUSE Linux Enterprise Server 12-SP2-BCL (src): xorg-x11-server-7.6_1.18.3-76.37.1 SUSE Enterprise Storage 5 (src): xorg-x11-server-7.6_1.18.3-76.37.1 HPE Helion Openstack 8 (src): xorg-x11-server-7.6_1.18.3-76.37.1 NOTE: This line indicates an update has been released for the listed product(s). At times this might be only a partial fix. If you have questions please reach out to maintenance coordination.
SUSE-SU-2020:14553-1: An update that fixes two vulnerabilities is now available. Category: security (important) Bug References: 1174908,1177596 CVE References: CVE-2020-14360,CVE-2020-25712 JIRA References: Sources used: SUSE Linux Enterprise Server 11-SP4-LTSS (src): xorg-x11-server-7.4-27.122.37.1 SUSE Linux Enterprise Point of Sale 11-SP3 (src): xorg-x11-server-7.4-27.122.37.1 SUSE Linux Enterprise Debuginfo 11-SP4 (src): xorg-x11-server-7.4-27.122.37.1 SUSE Linux Enterprise Debuginfo 11-SP3 (src): xorg-x11-server-7.4-27.122.37.1 NOTE: This line indicates an update has been released for the listed product(s). At times this might be only a partial fix. If you have questions please reach out to maintenance coordination.
openSUSE-SU-2020:2147-1: An update that fixes two vulnerabilities is now available. Category: security (important) Bug References: 1174908,1177596 CVE References: CVE-2020-14360,CVE-2020-25712 JIRA References: Sources used: openSUSE Leap 15.2 (src): xorg-x11-server-1.20.3-lp152.8.12.1
openSUSE-SU-2020:2186-1: An update that fixes two vulnerabilities is now available. Category: security (important) Bug References: 1174908,1177596 CVE References: CVE-2020-14360,CVE-2020-25712 JIRA References: Sources used: openSUSE Leap 15.1 (src): xorg-x11-server-1.20.3-lp151.4.9.1
Released.